zjw1111 commented on code in PR #205:
URL: https://github.com/apache/paimon-cpp/pull/205#discussion_r3782371976
##########
src/paimon/fs/oss/oss_file_system_factory.h:
##########
@@ -0,0 +1,35 @@
+/*
+ * Copyright 2026-present Alibaba Inc.
Review Comment:
please use ASF license
##########
CMakeLists.txt:
##########
@@ -85,6 +88,9 @@ endif()
if(PAIMON_ENABLE_JINDO)
add_definitions(-DPAIMON_ENABLE_JINDO)
endif()
+if(PAIMON_ENABLE_OSS)
Review Comment:
could you add oss and s3 options in the docs (`docs/source/building.rst` and
`docs/source/build_system.rst`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
