zjw1111 commented on code in PR #205:
URL: https://github.com/apache/paimon-cpp/pull/205#discussion_r3782441023
##########
cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1359,6 +1373,106 @@ macro(build_jindosdk_nextarch)
add_dependencies(jindosdk::nextarch jindosdk-nextarch_ep)
endmacro()
+macro(build_oss_sdk_v2)
+ message(STATUS "Building Alibaba Cloud OSS C++ SDK v2 from source")
+ find_package(CURL REQUIRED)
+ find_package(Threads REQUIRED)
+
+ set(OSS_SDK_V2_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/oss_sdk_v2_ep-install")
+ set(OSS_SDK_V2_INCLUDE_DIR "${OSS_SDK_V2_PREFIX}/include")
+ set(OSS_SDK_V2_INSTALL_LIBDIR "${CMAKE_INSTALL_LIBDIR}")
+ set(OSS_SDK_V2_LIB_DIR "${OSS_SDK_V2_PREFIX}/${OSS_SDK_V2_INSTALL_LIBDIR}")
+ set(OSS_SDK_V2_STATIC_LIB
+
"${OSS_SDK_V2_LIB_DIR}/${CMAKE_STATIC_LIBRARY_PREFIX}alibabacloud-oss-cpp-sdk-v2${CMAKE_STATIC_LIBRARY_SUFFIX}"
+ )
+
+ set(OSS_SDK_V2_CMAKE_CXX_FLAGS "${EP_CXX_FLAGS} -Wno-error")
+ set(OSS_SDK_V2_CMAKE_C_FLAGS "${EP_C_FLAGS} -Wno-error")
+ string(REPLACE "-Werror" "" OSS_SDK_V2_CMAKE_CXX_FLAGS
${OSS_SDK_V2_CMAKE_CXX_FLAGS})
+
+ set(OSS_SDK_V2_CMAKE_ARGS
+ ${EP_COMMON_CMAKE_ARGS}
+ "-DCMAKE_INSTALL_PREFIX=${OSS_SDK_V2_PREFIX}"
+ "-DCMAKE_INSTALL_LIBDIR=${OSS_SDK_V2_INSTALL_LIBDIR}"
+ "-DCMAKE_CXX_FLAGS=${OSS_SDK_V2_CMAKE_CXX_FLAGS}"
+ "-DCMAKE_C_FLAGS=${OSS_SDK_V2_CMAKE_C_FLAGS}"
+ -DCMAKE_PARENT_CXX_STANDARD=17
+ -DBUILD_SHARED_LIBS=OFF
+ -DBUILD_TESTS=OFF
+ -DBUILD_SAMPLES=OFF
+ -DENABLE_RTTI=OFF
+ -DUSE_CURL_TRANSPORT=ON
+ -DUSE_SYSTEM_CURL=ON
+ -DUSE_SYSTEM_OPENSSL=OFF
+ -DUSE_SYSTEM_MBEDTLS=OFF
+ -DUSE_SYSTEM_TINYXML2=OFF
+ -DUSE_STD_EXPECTED=OFF
+ -DENABLE_ENCRYPTION=OFF)
+ set(OSS_SDK_V2_CURL_INCLUDE_DIR "${CURL_INCLUDE_DIR}")
+ if(NOT OSS_SDK_V2_CURL_INCLUDE_DIR AND CURL_INCLUDE_DIRS)
+ list(GET CURL_INCLUDE_DIRS 0 OSS_SDK_V2_CURL_INCLUDE_DIR)
+ endif()
+ set(OSS_SDK_V2_CURL_LIBRARY "${CURL_LIBRARY_RELEASE}")
+ if(NOT OSS_SDK_V2_CURL_LIBRARY)
+ set(OSS_SDK_V2_CURL_LIBRARY "${CURL_LIBRARY}")
+ endif()
+ if(TARGET CURL::libcurl)
+ if(NOT OSS_SDK_V2_CURL_INCLUDE_DIR)
+ get_target_property(OSS_SDK_V2_CURL_INCLUDE_DIR CURL::libcurl
+ INTERFACE_INCLUDE_DIRECTORIES)
+ endif()
+ if(NOT OSS_SDK_V2_CURL_LIBRARY)
+ foreach(CURL_CONFIG RELEASE RELWITHDEBINFO DEBUG NOCONFIG)
+ get_target_property(OSS_SDK_V2_CURL_LIBRARY CURL::libcurl
+ "IMPORTED_LOCATION_${CURL_CONFIG}")
+ if(OSS_SDK_V2_CURL_LIBRARY)
+ break()
+ endif()
+ endforeach()
+ endif()
+ if(NOT OSS_SDK_V2_CURL_LIBRARY)
+ get_target_property(OSS_SDK_V2_CURL_LIBRARY CURL::libcurl
IMPORTED_LOCATION)
+ endif()
+ endif()
+ if(OSS_SDK_V2_CURL_INCLUDE_DIR AND OSS_SDK_V2_CURL_LIBRARY)
+ list(APPEND
+ OSS_SDK_V2_CMAKE_ARGS
+ "-DCURL_INCLUDE_DIR=${OSS_SDK_V2_CURL_INCLUDE_DIR}"
+ "-DCURL_LIBRARY=${OSS_SDK_V2_CURL_LIBRARY}"
+ "-DCURL_LIBRARY_RELEASE=${OSS_SDK_V2_CURL_LIBRARY}")
+ endif()
+
+ externalproject_add(oss_sdk_v2_ep
+ ${EP_COMMON_OPTIONS}
+ URL ${OSS_SDK_V2_SOURCE_URL}
+ URL_HASH
"SHA256=${PAIMON_OSS_SDK_V2_BUILD_SHA256_CHECKSUM}"
+ CMAKE_ARGS ${OSS_SDK_V2_CMAKE_ARGS}
+ PATCH_COMMAND bash -c
+ "perl -0pi -e
's/\"-Wall\"\\s+\"-Werror\"\\s+\"-pedantic\"\\s+\"-Wextra\"/\"-Wall\"
\"-pedantic\" \"-Wextra\"/g' <SOURCE_DIR>/sdk/CMakeLists.txt"
+ COMMAND bash -c
+ "perl -0pi -e 's/#if LIBCURL_VERSION_NUM >=
0x074400/#if 0/g' <SOURCE_DIR>/sdk/src/transport/curl/CurlMultiTransport.cpp"
+ COMMAND bash -c
+ "perl -0pi -e 's/#if LIBCURL_VERSION_NUM >=
0x074200/#if 0/g' <SOURCE_DIR>/sdk/src/transport/curl/CurlMultiTransport.cpp"
+ COMMAND bash -c
+ "perl -0pi -e
's/request->headers\\.emplace\\(\"Authorization\",
credentialHeader\\)\\x3b/request->headers.insert_or_assign(\"Authorization\",
credentialHeader)\\x3b/g' <SOURCE_DIR>/sdk/src/signer/SignerV1.cpp"
+ COMMAND bash -c
+ "perl -0pi -e
's/request->headers\\.emplace\\(\"Authorization\",
ss\\.str\\(\\)\\)\\x3b/request->headers.insert_or_assign(\"Authorization\",
ss.str())\\x3b/g' <SOURCE_DIR>/sdk/src/signer/SignerV4.cpp"
+ ${THIRDPARTY_LOG_OPTIONS}
Review Comment:
could you make the patch as a diff file (like `cmake_modules/jieba.diff`),
and add the diff file in `LICENSE` file like ↓
<img width="1874" height="534" alt="Image"
src="https://github.com/user-attachments/assets/cee51f66-64b2-4e75-90f8-d5c8713d1ac6";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
