wangyong9999 commented on code in PR #254: URL: https://github.com/apache/paimon-cpp/pull/254#discussion_r3871237291
########## src/paimon/common/utils/std_concurrent_hash_map.h: ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <algorithm> +#include <cstddef> +#include <cstdint> +#include <functional> +#include <mutex> +#include <optional> +#include <shared_mutex> +#include <string> +#include <unordered_map> +#include <vector> + +#include "paimon/common/utils/murmurhash_utils.h" + +namespace paimon { + +template <typename Key> +class DefaultHashCompare { + public: + size_t hash(const Key& key) const { + return std::hash<Key>{}(key); + } + + bool equal(const Key& lhs, const Key& rhs) const { + return lhs == rhs; + } +}; + +namespace detail { + +template <typename Key, typename HashCompare> +class HashCompareHasher { + public: + size_t operator()(const Key& key) const { + return HashCompare{}.hash(key); Review Comment: The previous issue is still present after this refactor: HashCompare{} is rebuilt for every hash/equality call. On this head, the same stateful-comparator repro still returns missing immediately after Insert when TBB is off (three comparator instances versus one with TBB). Please retain one comparator state per map and initialize both unordered-map adapters from it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
