gripleaf commented on PR #254: URL: https://github.com/apache/paimon-cpp/pull/254#issuecomment-5449541958
> Before starting the review, I’d like to better understand the specific motivation behind this PR — for example, which platform or downstream project is unable to use TBB, and what the performance trade-offs are when disabling it. BTW, the current CI also doesn’t seem to cover the `PAIMON_USE_TBB=OFF` branch. The motivation is not platform compatibility. We integrate Paimon C++ as a DSO to isolate its large dependency graph from the existing service. However, both the service and the DSO bring their own TBB runtime and worker pool, which can cause thread oversubscription. PAIMON_USE_TBB=OFF allows the DSO to avoid introducing the second TBB runtime. You are also right that CI currently does not cover PAIMON_USE_TBB=OFF; I will add a dedicated non-TBB build/test configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
