Copilot commented on code in PR #9715: URL: https://github.com/apache/paimon/pull/9715#discussion_r3978558631
########## paimon-python/pypaimon/tests/oss_atomic_write_test.py: ########## @@ -0,0 +1,244 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Exercise conditional OSS writes through the real SDK against a local HTTP server.""" + +import socket +import threading +from concurrent.futures import ThreadPoolExecutor +from http.server import BaseHTTPRequestHandler, HTTPServer +from socketserver import ThreadingMixIn +from unittest import mock +from urllib.parse import unquote, urlsplit + +import pyarrow.fs as pafs +import pytest + +from pypaimon.catalog.rest.rest_token import RESTToken +from pypaimon.catalog.rest.rest_token_file_io import RESTTokenFileIO +from pypaimon.common.file_io import FileIO +from pypaimon.common.identifier import Identifier +from pypaimon.common.options import Options +from pypaimon.common.options.config import CatalogOptions +from pypaimon.filesystem.oss_file_io import OssFileIO + +oss2 = pytest.importorskip("oss2") Review Comment: This module is skipped wholesale in the repository's Python CI because `oss2` is not installed by either `dev/requirements.txt` or the dependency-install step in `.github/workflows/paimon-python-checks.yml`. As a result, the new conditional-write implementation—including its concurrency, conflict, versioning-fallback, and SSE behavior—receives no automated coverage. Please install a compatible `oss2` version in at least one CI test lane (or otherwise make these tests non-skipping there). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
