JingsongLi commented on code in PR #9850:
URL: https://github.com/apache/paimon/pull/9850#discussion_r4055749231


##########
paimon-python/pypaimon/common/options/core_options.py:
##########
@@ -1128,6 +1128,19 @@ class CoreOptions:
         .with_description("Read batch size for any file format if it 
supports.")
     )
 
+    PARQUET_COLUMN_INDEX_ENABLED: ConfigOption[bool] = (
+        ConfigOptions.key("parquet.filter.columnindex.enabled")
+        .boolean_type()
+        .default_value(False)

Review Comment:
   [P2] Preserve the existing default for the shared Parquet option
   
   parquet.filter.columnindex.enabled is an existing parquet-mr option whose 
default is true, and Paimon forwards parquet.* table options to Java 
ParquetReadOptions. Defining the same key with a default of false makes its 
effective behavior differ between Java and PyPaimon when the option is absent. 
Please change this default to true. If the new PyPaimon OffsetIndex path must 
remain opt-in, it should use a separate PyPaimon-specific option instead.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to