JingsongLi commented on PR #941:
URL: https://github.com/apache/paimon-rust/pull/941#issuecomment-5831612925
Requirement fit: SUPPORTED, but **P1: preserve branches configured for
production reads.** This procedure calls `BranchManager::drop_branch` directly.
Paimon Java `AbstractFileStoreTable.deleteBranch` rejects deletion when the
name equals `scan.primary-branch` or `scan.fallback-branch`; those options
protect configured readers. I reproduced the gap at adb3aa5f: add `WITH
('scan.primary-branch' = 'b1')` to the PR integration test table, create `b1`,
then call `sys.delete_branch(..., branch => 'b1')`. The call succeeds and
removes `b1`. This can break Java or other readers using that configured
branch. Please check both table options before any deletion and add regression
tests for each, including a comma-separated request where one protected branch
appears. The original integration test and formatting check pass; all 14 CI
checks are green but do not cover this safety condition. Java reference:
https://github.com/apache/paimon/blob/master/paimon-core/src/main/java/org/apache/paimon
/table/AbstractFileStoreTable.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
