jackylee-ch commented on PR #941: URL: https://github.com/apache/paimon-rust/pull/941#issuecomment-5979890656
Thanks for the review — fixed in the latest commit (CI re-running). `delete_branch` no longer trims each comma token, so `branch => ' b1'` now deletes the branch literally named ` b1` instead of `b1`, matching Java `Table.deleteBranches`, which passes every split token through unchanged. The empty-token skip stays for trailing commas, and the pre-deletion name validation is unchanged. Added a test that seeds `b1` and ` b1`, deletes ` b1`, and asserts `b1` survives (it fails if the trim is restored). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
