zhuxiangyi commented on PR #10098:
URL: https://github.com/apache/paimon/pull/10098#issuecomment-5843645090
@JingsongLi thanks, confirmed with the same probe. Fixed by leaving the
procedure as the only way to switch the options on:
- 08f1e1c21: `SchemaChange.enableDataEvolution()` is removed from the public
API. The change now has a private constructor inside `DataEvolutionEnabler`, so
only the procedure (which always fences and repairs) can issue it. It still
goes through `catalog.alterTable`, so catalog locks and metastore sync are kept.
- 1566bc166: the same race existed on master via `ALTER TABLE SET
('row-tracking.enabled' = 'true')` on a table without snapshots. That is now
refused too (set it at `CREATE TABLE` or use the procedure). It is a separate
commit because it changes behaviour.
Your probe is added as a regression test
(`testAlterTableWithWriterInFlightOnTableWithoutSnapshot`). The requirement to
stop older-version writers is in the docs and will be at the top of the PR
description. The Core CI failures were the MinIO image pull in `S3FileIOTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
