jackylee-ch commented on PR #10199: URL: https://github.com/apache/paimon/pull/10199#issuecomment-5910538071
Thanks @zhuxiangyi. Reworked to mirror your #10204 approach instead of probing a snapshot id: cleanup deletes the protection tag only when the commit was never entered or returned `false`; if it threw after publishing (e.g. a post-commit callback), the tag is kept. I also dropped the Flink change so #10204 owns it — this PR is Spark-only now. Verified in `paimon-spark-ut`: new tests run the real `CALL` with a callback failure, with and without an interleaved commit, and assert the tag survives expiration; the old `latestSnapshot.id() + 1` cleanup fails the interleaved case. Added Spark docs; spotless clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
