jackylee-ch commented on PR #10173:
URL: https://github.com/apache/paimon/pull/10173#issuecomment-5911177644

   Reworked and rebased onto master. Since I opened this, #10202 landed native 
(Rust) primary-key value stats under `metadata.stats-mode` and added 
`native_write_capabilities_test`, so the native-route point is handled upstream 
— I dropped my native guard (it now regresses that test) and its unit test. 
This PR is purely the Python-writer fix.
   
   The row-id point is fixed: `_RowIdUpdateFileWriter` now converts its stats 
like the other writers, so under `counts` / `truncate(N)` it records the 
declared null counts (and truncated min/max) instead of empty stats under a 
`value_stats_cols=None` manifest. Verified in `metadata_stats_mode_test` and 
`table_upsert_by_key_test`; reverting the writer change fails exactly those. 
flake8 and `git diff --check` clean.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to