jackylee-ch commented on PR #10173: URL: https://github.com/apache/paimon/pull/10173#issuecomment-5967137652
Thanks — fixed the signed-zero P1 in 7b2bf356d. `SingleFileWriter`'s cross-group min/max merge now orders floats with Java's typed comparison (`-0.0` < `+0.0`) instead of Python `min`/`max`, so a row-id update whose groups hold `-0.0` and `+0.0` publishes min=`-0.0` / max=`+0.0` regardless of group order. Non-float columns keep plain `min`/`max`; the NaN/ns omission flag is unchanged (single-group Arrow min/max was already correct — only the incremental merge was wrong). Added `test_row_id_update_file_merges_signed_zero_bounds`: a two-row-group row-id update under `truncate(3)`, both orders, asserting the sign bits of the published min/max. Reverting to Python `min`/`max` fails it (max comes back `-0.0`). flake8 and `git diff --check` clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
