jackylee-ch commented on PR #939: URL: https://github.com/apache/paimon-rust/pull/939#issuecomment-5980321974
Thanks for the review — both findings fixed in the latest commit (CI re-running). Source branch: `create_branch` now resolves a branch-qualified source (`t1$branch_b1`) to the base table plus a source branch, reading the tag/snapshot/schema from that branch while creating the new branch flat under the table root (matching Java `FileSystemBranchManager`). REST ownership: it now refuses REST-managed tables before writing any branch files, since the Rust REST catalog has no branch-create endpoint yet. Tests: a core test seeds a tag living only on `b1`; a SQL test creates `b2` from `t1$branch_b1` after dropping the main tag; a REST-backed test asserts the refusal. Each fails if its fix is reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
