JingsongLi commented on PR #939: URL: https://github.com/apache/paimon-rust/pull/939#issuecomment-5831641417
Requirement fit: SUPPORTED. Normal branch creation, duplicate handling, and a branch created from a tag worked in local DataFusion SQL tests. However, **P1: reject path separators in branch names.** The shared `BranchManager::validate_branch_name` allows `b1/hidden`. I reproduced this at 697e6c92: after creating `b1`, `CALL sys.create_branch(table => 'test_db.t1', branch => 'b1/hidden')` succeeds, but `SELECT * FROM t1$branches WHERE branch_name = 'b1/hidden'` returns zero rows. The branch is created underneath `branch-b1` and is invisible to normal branch listing. Please validate names at the shared manager boundary before writing any schema/tag/snapshot files, and add a SQL regression confirming an invalid name fails without creating files. Original PR test, a temporary from-tag test, formatting and diff checks pass; CI is green but misses this case. Temporary test edits were restored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
