jackylee-ch commented on PR #1019: URL: https://github.com/apache/paimon-rust/pull/1019#issuecomment-5981995140
Thanks — the remaining validation finding is fixed in the latest commit (CI re-running). `updateColumnDefaultValue` now validates the new default against the column type before the altered schema is persisted, mirroring Java `SchemaValidation.validateDefaultValues`. The check reuses the exact per-column cast the Format Table writer applies, so altering an INT default to `bad` is refused and the previous schema stays usable, instead of advancing the schema and disabling every later write. `FileSystemCatalog::alter_table` runs it after applying changes, before saving. Added a test: a castable default is accepted, an uncastable INT default is refused, and the previous valid default survives (fails if the guard is removed). Scope note: this covers the alter path (the finding); a REST catalog validates server-side, and create-time Format Table validation is a separate pre-existing gap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
