JeonDaehong commented on code in PR #1145:
URL: https://github.com/apache/paimon-rust/pull/1145#discussion_r4314297706
##########
crates/paimon/src/table/global_index_scanner.rs:
##########
@@ -385,11 +385,19 @@ impl GlobalIndexScanner {
predicate: &Predicate,
evaluated_fields: &std::collections::HashSet<i32>,
) -> bool {
- use crate::spec::PredicateOperator;
+ use crate::spec::{DataType, PredicateOperator};
match predicate {
Predicate::NestedLeaf { .. } => false,
- Predicate::Leaf { column, op, .. } => {
+ Predicate::Leaf {
+ column,
+ op,
+ data_type,
+ ..
+ } => {
predicates::is_sorted_global_index_supported_op(*op)
+ // Bitmap answers these with every non-null row.
+ && !(matches!(data_type, DataType::Float(_) |
DataType::Double(_))
+ &&
super::bitmap_global_index_format::is_bitmap_floating_residual_sensitive_op(*op))
Review Comment:
Right, the downgrade was keyed on the predicate, not on the index that
answered it. Fixed in ae3660e. `evaluate_leaf` now marks a leaf inexact only
when a bitmap entry answered a floating range or negation, so BTree results
stay exact. I reverted the check in `is_exact_predicate`.
`floating_bitmap_candidates_are_refined_before_top_k` now also runs on
BTree, with and without `refine-from-data=false`. Before this change, BTree +
`refine-from-data=false` returned `[]`.
I also rebased onto current main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
