JeonDaehong commented on code in PR #1145:
URL: https://github.com/apache/paimon-rust/pull/1145#discussion_r4400373477
##########
crates/paimon/src/table/global_index_scanner/evaluator.rs:
##########
@@ -748,7 +761,7 @@ impl GlobalIndexScanner {
Ok(Some((
crate::table::merge_row_ranges(all_ranges),
coverage(),
- fully_evaluated,
+ fully_evaluated && !(bitmap_retained && bitmap_superset_ops),
Review Comment:
makes sense, a flag can't say where the candidates are. the bitmap part is
now kept as row ranges instead of a bool, and both callers only treat the
answer as inexact if those ranges overlap the rows they actually use: the
vector ranges in scalar_matched_row_ids, and the decided rows in the full-text
filter (c0bde05). added your partitioned case as a test, it returns [0] for all
six mode/refine combinations, and [] in FULL/DETAIL with refine off before this
commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
