JeonDaehong commented on code in PR #1145:
URL: https://github.com/apache/paimon-rust/pull/1145#discussion_r4373589928
##########
crates/paimon/src/table/global_index_scanner/evaluator.rs:
##########
@@ -670,9 +680,11 @@ impl GlobalIndexScanner {
// Only a proven identity remains (other conjuncts may have
// declined their budget). Preserve its indexed domain and
// leave the residual filter to the ordinary table reader.
+ bitmap_retained |= matches!(entry.index_type,
GlobalIndexFileKind::Bitmap);
all_matching_ranges.push(RowRange::new(entry.row_range_start,
entry.row_range_end));
continue;
}
+ bitmap_retained |= matches!(entry.index_type,
GlobalIndexFileKind::Bitmap);
Review Comment:
right, it was set when the query was planned, not when rows came back. now
it's only set when a bitmap shard actually returns ranges (1f119c2). added your
case as a test: bitmap shard f=[1,3], BTree on the later rows, `f > 1.5 AND f =
2`. it returns [] without the fix and [2] with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
