Akash3121 commented on code in PR #10688:
URL: https://github.com/apache/paimon/pull/10688#discussion_r4372065095
##########
paimon-core/src/main/java/org/apache/paimon/index/pk/BucketedPrimaryKeyIndexMaintainer.java:
##########
@@ -55,16 +57,16 @@
/** Coordinates all source-backed primary-key indexes for one bucket. */
public final class BucketedPrimaryKeyIndexMaintainer {
- @Nullable private final BucketedVectorIndexMaintainer vectorMaintainer;
+ private final List<BucketedVectorIndexMaintainer> vectorMaintainers;
Review Comment:
Renaming this field breaks
`PrimaryKeyIndexWriteTest.testCreatesCoordinatorForMultipleScalarDefinitionsAndVector`,
which still calls `readField(..., "vectorMaintainer")` at line 142. Both Core
JDK 8 and JDK 11 CI fail with `NoSuchFieldException`. Please read
`vectorMaintainers`, assert that the list has one entry, and use its first
maintainer for the existing deletion-vector-factory assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]