tzphh commented on code in PR #10688:
URL: https://github.com/apache/paimon/pull/10688#discussion_r4386137552


##########
paimon-core/src/main/java/org/apache/paimon/index/pk/BucketedPrimaryKeyIndexMaintainer.java:
##########
@@ -55,16 +57,16 @@
 /** Coordinates all source-backed primary-key indexes for one bucket. */
 public final class BucketedPrimaryKeyIndexMaintainer {
 
-    @Nullable private final BucketedVectorIndexMaintainer vectorMaintainer;
+    private final List<BucketedVectorIndexMaintainer> vectorMaintainers;

Review Comment:
   Fixed in 0479ef5dcc. The test now reads `vectorMaintainers`, asserts that it 
contains one maintainer, and uses that maintainer for the existing 
deletion-vector factory assertion. All 19 focused Core tests passed locally on 
this CR1 head, including the previously failing test (JDK 17).
   
   I also verified the combined head e787eb7f96, which includes this fix, on 
JDK 8 (1.8.0_512) and JDK 11 (11.0.27). All 139 focused Core tests passed on 
each runtime, including this regression test.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to