tzphh commented on PR #10688: URL: https://github.com/apache/paimon/pull/10688#issuecomment-6435965263
Fixed in 0479ef5dcc: the writer test now reads `vectorMaintainers`, asserts one entry, and keeps the deletion-vector factory assertion. The correction is included in CR1 itself and propagated to CR2, rather than relying on CR3. Validation on this CR1 head: 19 focused Core tests passed, including the previously failing `PrimaryKeyIndexWriteTest`; Spotless, Checkstyle, Enforcer, and diff checks passed. Local runtime: JDK 17 / Maven 3.9.10. JDK 8/11 CI will validate those runtimes separately. Addresses [the inline feedback](https://github.com/apache/paimon/pull/10688#discussion_r4372065095) and [the follow-up](https://github.com/apache/paimon/pull/10688#issuecomment-6409227710). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
