lszskye commented on code in PR #447:
URL: https://github.com/apache/paimon-cpp/pull/447#discussion_r4386376121
##########
src/paimon/core/schema/schema_validation.cpp:
##########
@@ -76,6 +76,29 @@ namespace {
constexpr char kDeletionVectorsMergeOnRead[] =
"deletion-vectors.merge-on-read";
+/// The options a copy is refused to change, mirroring the Java
`SchemaManagerUtils#
+/// checkAlterTableOption` over the immutable options the C++ side has
constants for. They name
+/// the physical layout the data on the table's path was written by: a
`bucket-key` the options
+/// rename, say, re-hashes the bucket pruning while the files stay hashed by
the old key, so the
+/// scans a copy serves would filter out the buckets its rows are actually in.
The check runs over
+/// every option the call gives, before the merge, so it holds on every path
that merges options
+/// into a table. Unlike the Java set, `merge-engine`, `bucket`,
`row-tracking.enabled` and
+/// `data-evolution.enabled` stay servable as dynamic options here, and
`type`/`branch` are dropped
+/// by `Copy` before this point.
+const char* const kImmutableOptions[] = {
+ Options::BUCKET_KEY,
+ Options::BUCKET_FUNCTION_TYPE,
+ Options::AGGREGATION_REMOVE_RECORD_ON_DELETE,
+ Options::PARTIAL_UPDATE_REMOVE_RECORD_ON_DELETE,
+ Options::PARTIAL_UPDATE_REMOVE_RECORD_ON_SEQUENCE_GROUP,
+ Options::FORCE_LOOKUP,
+ Options::INDEX_FILE_IN_DATA_FILE_DIR,
+ Options::BLOB_FIELD,
+ Options::FALLBACK_BLOB_DESCRIPTOR_FIELD,
+ Options::BLOB_VIEW_FIELD,
+ Options::PK_CLUSTERING_OVERRIDE,
+};
Review Comment:
please add a TODO list for all keys like `merge-engine`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]