SteNicholas commented on code in PR #447:
URL: https://github.com/apache/paimon-cpp/pull/447#discussion_r4385183689
##########
src/paimon/core/table/system/system_table.cpp:
##########
@@ -176,6 +182,40 @@ std::optional<SystemTableFactory>
FindSystemTableFactory(const std::string& syst
} // namespace
+SystemTable::SystemTable(const std::shared_ptr<FileSystem>& fs, const
std::string& table_path)
+ : Table(fs, table_path, /*schema=*/nullptr,
+ Identifier(Identifier::kUnknownDatabase, "system_table"),
/*uuid=*/"") {}
+
+Status SystemTable::CheckNoSearch(const std::shared_ptr<ReadContext>& context)
{
+ if (context->HasVectorOrFullTextSearch()) {
+ return Status::NotImplemented(
+ "VectorSearch or FullTextSearch does not support system-table
reads yet");
+ }
+ return Status::OK();
Review Comment:
**Reject FullTextMatch on direct system-table reads**.
`HasVectorOrFullTextSearch()` only checks TopK requests; it does not detect
`FullTextMatch` predicates supplied through
`ReadContextBuilder::SetPredicate()`. Calling `NewRead()` on an in-memory
system table (for example, `t$options`) therefore passes this guard and returns
all rows without evaluating the predicate. The static `TableRead::Create()`
path rejects the same request with `NotImplemented`.
Please also check
`PredicateUtils::ContainsFullTextMatch(context->GetPredicate())` here and add a
regression test through the direct `Table::NewRead()` entry point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]