lszskye commented on code in PR #447:
URL: https://github.com/apache/paimon-cpp/pull/447#discussion_r4385746497


##########
src/paimon/core/operation/internal_read_context.h:
##########
@@ -56,10 +58,40 @@ class InternalReadContext {
         std::string field_name;
     };
 
+    /// Builds the context of a read a table serves: the options are the 
table's own, already
+    /// parsed, and the cache the context carries is armed on them here. 
`path` names the root path
+    /// the table was opened with, which the read reads from in place of the 
context's own.
+    static Result<std::unique_ptr<InternalReadContext>> Create(
+        const std::shared_ptr<ReadContext>& read_context,
+        const std::shared_ptr<TableSchema>& table_schema, CoreOptions 
core_options,
+        const std::string* path = nullptr);
+
+    /// Builds the context of a read whose options are composed on the spot 
rather than the table's
+    /// own - the fallback branch of a read, whose schema belongs to another 
branch, and the reads a
+    /// write or a lookup serve inside themselves. The read's own file system 
is `file_system`, or
+    /// the context's when null; the scheme map the context carries does not 
take part.
     static Result<std::unique_ptr<InternalReadContext>> Create(
         const std::shared_ptr<ReadContext>& read_context,
         const std::shared_ptr<TableSchema>& table_schema,
-        const std::map<std::string, std::string>& options);
+        const std::map<std::string, std::string>& options,
+        const std::shared_ptr<FileSystem>& file_system = nullptr,
+        const std::string* path = nullptr);

Review Comment:
   +1,adding an extra `path` is a bit odd.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to