skyyyy955 opened a new pull request, #10907:
URL: https://github.com/apache/paimon/pull/10907

   ### Purpose
   
   Fix temporary-directory cleanup failures on Windows in 
`RowFormatReadWriteTest` and `BlockPrefetcherTest`. Their write helpers and the 
BLOB/VECTOR test close `RowFormatWriter`, which writes the footer and flushes 
the supplied stream but does not close it. The tests leave their file handles 
open.
   
   Use try-with-resources for the three output streams. Keep `writer.close()` 
inside each scope so the footer is written before the underlying stream closes. 
Test data, assertions and production code are unchanged.
   
   The existing tests were introduced by JingsongLi in #7934. This change only 
handles their output-stream lifetime; it does not change the ROW writer's 
ownership contract.
   
   ### Tests
   
   Ran both complete classes at `cb51a8be367cf1c86335606edb14b982f769069f`:
   
   | Environment | Before | After |
   | --- | --- | --- |
   | Windows / JDK 8u451 | 9 passed, 33 temporary-directory cleanup errors | 42 
passed |
   | Linux / JDK 8u441 | 42 passed | 42 passed |
   
   `mvn -o -B -ntp -pl paimon-format -am -DwildcardSuites=none 
-DfailIfNoTests=false -Dtest=RowFormatReadWriteTest,BlockPrefetcherTest test`
   
   No `fast-build` profile was used. Spotless and Enforcer passed on both 
platforms, and Checkstyle passed on Linux outside a `target`-suppressed source 
path. Full-module tests and RAT were not run.
   
   The branch is based on `0369648333b9278d4d61a0768cf355f3299ec111`. Compared 
with the tested base, only 14 Python source/test, Python CI and Python 
documentation files differ; all Java/build inputs and the test patch are 
identical. Tests were not repeated after this base change.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to