JingsongLi commented on PR #10907: URL: https://github.com/apache/paimon/pull/10907#issuecomment-6556842624
The stream ownership change is technically correct: each test finishes `RowFormatWriter` before closing the supplied stream. I ran both complete test classes on JDK 8/macOS with normal Maven `verify`: all 42 cases pass, including Checkstyle, Spotless, Enforcer and RAT. I also checked the failed Spark 4 CI job: it stops resolving `org.apache:apache:pom:23` with a Maven Central HTTP 403, before compilation/tests; that is not a code finding against this patch. Windows was not independently run here. The demonstrated problem is confined to test-owned output streams and temporary-directory cleanup on Windows. Production file writes already have an owner: `SingleFileWriter.close()` finishes the format writer, flushes/closes `out`, and aborts/cleans up if closing fails. Neither that path nor ROW storage/read semantics changes in this PR. Closing this standalone test cleanup under the current end-to-end production contribution scope. The implementation itself looks correct; this can accompany a concrete supported-platform or functional change rather than being treated as a deployed file-handle/resource fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
