LsomeYeah commented on code in PR #10860:
URL: https://github.com/apache/paimon/pull/10860#discussion_r4440720592
##########
paimon-core/src/main/java/org/apache/paimon/table/FallbackReadFileStoreTable.java:
##########
@@ -246,7 +267,53 @@ public DataTableScan
newFallbackScan(Function<FileStoreTable, DataTableScan> sca
validateSchema();
FileStoreTable first = wrappedFirst ? wrapped : other;
FileStoreTable second = wrappedFirst ? other : wrapped;
- return new FallbackReadScan(first, second, wrapped.schema(),
scanCreator);
+ boolean otherIsEmpty =
+ other.coreOptions().scanSnapshotId() != null
Review Comment:
Thanks for catching this! Empty branches are now marked with snapshot ID
`-1`, so later commits cannot change the resolved read. Added regression tests
for both fallback and primary branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
