LsomeYeah commented on code in PR #10860:
URL: https://github.com/apache/paimon/pull/10860#discussion_r4477452422
##########
paimon-core/src/main/java/org/apache/paimon/table/FallbackReadFileStoreTable.java:
##########
@@ -246,7 +276,57 @@ public DataTableScan
newFallbackScan(Function<FileStoreTable, DataTableScan> sca
validateSchema();
FileStoreTable first = wrappedFirst ? wrapped : other;
FileStoreTable second = wrappedFirst ? other : wrapped;
- return new FallbackReadScan(first, second, wrapped.schema(),
scanCreator);
+ if (coreOptions().isChainTable()) {
+ return new FallbackReadScan(first, second, wrapped.schema(),
scanCreator);
+ }
+ boolean otherIsEmpty =
+ Objects.equals(other.coreOptions().scanSnapshotId(),
EMPTY_BRANCH_SNAPSHOT_ID)
+ || (other.coreOptions().scanSnapshotId() != null
+ && other.snapshotManager().latestSnapshotId()
== null);
Review Comment:
Thanks for the detailed review! The factory path now uses the same
time-alignment logic as copy(). Added regression coverage, and all 103 targeted
tests pass locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]