JingsongLi commented on code in PR #1145:
URL: https://github.com/apache/paimon-rust/pull/1145#discussion_r4456427130


##########
crates/paimon/src/table/global_index_scanner/evaluator.rs:
##########
@@ -350,6 +391,7 @@ impl GlobalIndexScanner {
                             Some(child_result) => {
                                 fully_evaluated &= 
child_result.fully_evaluated;
                                 all_ranges.extend(child_result.row_ranges);
+                                
candidate_ranges.extend(child_result.candidate_ranges);

Review Comment:
   [P2] Preserve exact OR matches when another arm returns candidates
   
   Unioning child candidate ranges here marks a row uncertain even when another 
OR arm proves it matches. With a floating Bitmap index over f=[0,1], `f < 0 OR 
f = 1` gets both non-null rows as candidates from the range arm, while equality 
proves the f=1 row. With `global-index.filter.refine-from-data=false`, the 
vector consumer subtracts the combined candidates and returns [] instead of the 
proven match. I reproduced this through public write/index-build/search/read 
APIs in FAST, FULL and DETAIL (query [1,0], top-1, with the f=1 row nearest); 
exact-only and refinement-enabled controls pass. The identical probe passes on 
merge-base ed9df781, so this is introduced by the new candidate propagation. 
For OR, retain the union of proven child matches and exclude those rows from 
the final candidate set, respecting each child's exactness. Please cover 
overlapping candidate/exact OR branches in vector and full-text consumers.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to