JingsongLi commented on code in PR #11017:
URL: https://github.com/apache/paimon/pull/11017#discussion_r4522940426


##########
paimon-core/src/main/java/org/apache/paimon/table/sink/CommitMessageSerializer.java:
##########
@@ -53,7 +53,7 @@
 /** {@link VersionedSerializer} for {@link CommitMessage}. */
 public class CommitMessageSerializer implements 
VersionedSerializer<CommitMessage> {
 

Review Comment:
   **[P2] Preserve rollback compatibility for checkpoints with ordinary commit 
messages**
   
   I staged two partition commit messages on an ordinary table with guards 
disabled. The new serializer wrote both with inner version 15 and a trailing 
generation-presence byte per message inside `ManifestCommittable` version 5. 
The new reader decoded both. The previous version 14 reader accepted the outer 
envelope, left the new byte unread, then failed on the next message with 
`BufferUnderflowException`. This affects the savepoint produced by an upgraded 
job even when it never uses guards. Could the ordinary message list retain the 
old encoding when no generation is present, or make the rollback restriction 
explicit and reject the unsupported envelope clearly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to