junmuz commented on code in PR #11017:
URL: https://github.com/apache/paimon/pull/11017#discussion_r4566959751
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -1241,6 +1304,27 @@ private CommitResult tryCommitOnceWithoutLock(
List<ManifestEntry> deltaFiles = changes.tableFiles;
List<ManifestEntry> changelogFiles = changes.changelogFiles;
List<IndexManifestEntry> indexFiles = changes.indexFiles;
+ boolean replacesGuards =
+ indexFiles.stream()
+ .anyMatch(
+ entry ->
+ entry.kind() == FileKind.DELETE
+ &&
DELETE_ORDERING_GUARD.equals(
+
entry.indexFile().indexType()));
+ boolean publishesGuards =
Review Comment:
Each compaction publication attempt now validates the writer’s observed
guard files against the current committed set for the affected partition and
bucket, including publication retries. A changed set rejects the commit and
requires reopening the writer and recomputing compaction/changelog output.
Added real-writer regressions for lookup and full-compaction changelogs, a
publication-retry race, and an unrelated-partition control.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]