junmuz commented on code in PR #11017:
URL: https://github.com/apache/paimon/pull/11017#discussion_r4566963528
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java:
##########
@@ -1817,6 +1938,24 @@ private Pair<Boolean, CommitCallback.Context>
rollbackToAsLatestOnceWithoutLock(
// the snapshots between the target and the previous latest, breaking
the global uniqueness
// of _ROW_ID. Keep the larger of the previous latest and the target
nextRowId.
Long nextRowId = maxNextRowId(latest.nextRowId(),
targetSnapshot.nextRowId());
+ Map<String, String> rollbackProperties =
+ SequenceSnapshotProperties.mergeGuardMaxSequenceNumber(
+ targetSnapshot.properties(), latest, deltaFiles,
false);
+ rollbackProperties =
+ DeleteOrderingGuardGeneration.merge(
Review Comment:
Destructive snapshot/tag rollback now rejects histories with capture enabled
or tracked guard history, including after capture is disabled or the table is
truncated. The check also handles a latest hint pointing to a missing snapshot.
PyPaimon rejects before catalog delegation or local cleanup.
`rollbackToAsLatest` remains the supported restoration path. Regression tests
verify that the exact staged committable remains fenced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]