lszskye commented on code in PR #546:
URL: https://github.com/apache/paimon-cpp/pull/546#discussion_r4595082018


##########
include/paimon/file_index/file_index_reader.h:
##########
@@ -42,23 +41,12 @@ struct FullTextMatch;
 /// whether a given data file may contain rows matching a specific predicate.
 /// @note Callers of `Visit*` for DECIMAL fields must ensure each literal's 
scale matches the scale
 /// of the indexed data; otherwise, index filtering results may be incorrect.
-class PAIMON_EXPORT FileIndexReader : public 
FunctionVisitor<std::shared_ptr<FileIndexResult>> {
+/// TODO(lisizhuo.lsz): Add selectivity estimates for scalar indexes such as 
bitmap indexes.

Review Comment:
   move this TODO into index_reader_capabilities.h



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to