lszskye commented on code in PR #546:
URL: https://github.com/apache/paimon-cpp/pull/546#discussion_r4608781816
##########
src/paimon/core/table/source/append_only_table_read.cpp:
##########
@@ -221,6 +222,8 @@ Result<std::unique_ptr<BatchReader>>
AppendOnlyTableRead::CreateRealtimeReader(
if (!memory_range || memory_range->end !=
realtime_split->MemoryEndOffset()) {
return Status::Invalid("real-time read-view ticket does not match the
split offset range");
}
Review Comment:
move
`std::shared_ptr<arrow::Schema> table_schema =
DataField::ConvertDataFieldsToArrowSchema(context_->GetTableSchema()->Fields());`
to here and just call `memory.ValidateTableSchema(table_schema)` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]