PyRSA commented on code in PR #11163:
URL: https://github.com/apache/paimon/pull/11163#discussion_r4638119213


##########
paimon-python/pypaimon/write/backend_dispatch.py:
##########
@@ -254,6 +259,9 @@ def prepare():
 def prepare_native_write_operation(operation, table, commit_user, *args, 
**kwargs):
     if not table.options.native_write_enabled():
         return None
+    from pypaimon.common.native_compatibility import require_native_compatible
+    if require_native_compatible(table.options, allow_python_fallback=True) is 
not None:

Review Comment:
   Thanks for identifying this separate MERGE path. Fixed by checking the 
source table's effective compatibility policy before creating the Native 
source. Incompatible sources now use the existing Python MERGE fallback.



##########
paimon-python/pypaimon/write/backend_dispatch.py:
##########
@@ -97,6 +97,11 @@ def _prepare_write(table, commit_user, static_partition, 
stream,
     from pypaimon.read.merge_engine_support import 
check_sequence_field_supported
     check_sequence_field_supported(table)
     if table.options.native_write_enabled():
+        from pypaimon.common.native_compatibility import 
require_native_compatible
+        # nested-sequence-overwrite-on-equal=false must not enter Native write.
+        if require_native_compatible(table.options, 
allow_python_fallback=True) is not None:

Review Comment:
   Thanks for identifying the ROW-valued sequence case. Fixed by making Python 
sequence comparison schema-aware and recursive for ROW types, preserving schema 
field order and NULLS FIRST semantics.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to