PyRSA commented on code in PR #11163:
URL: https://github.com/apache/paimon/pull/11163#discussion_r4651985921


##########
paimon-python/pypaimon/execution/python/read/reader/aggregate/aggregators.py:
##########
@@ -229,16 +231,56 @@ def _compare_objects(left: Any, right: Any) -> int:
     if right is None:
         return 1
 
+    if isinstance(data_type, RowType):
+        return _compare_row_values(left, right, data_type)
+
     return (left > right) - (left < right)

Review Comment:
   Fixed the ROW sequence comparison to match Java ordering semantics, 
including recursive ARRAY comparison, NULLS FIRST, and FLOAT/DOUBLE handling. 
Added regression tests covering these cases.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to