ConeyLiu commented on code in PR #1187:
URL: https://github.com/apache/parquet-mr/pull/1187#discussion_r1426083327
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java:
##########
@@ -80,10 +80,12 @@ static final class ColumnChunkPageReader implements
PageReader {
private final byte[] dataPageAAD;
private final byte[] dictionaryPageAAD;
+ ParquetMetricsCallback metricsCallback;
Review Comment:
It would be better to mark it as final. I suggest getting `callback` from
`ParquetReadOptions` and then we don't need to update the constructor and more
reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
