ConeyLiu commented on code in PR #1187:
URL: https://github.com/apache/parquet-mr/pull/1187#discussion_r1432352599
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java:
##########
@@ -123,10 +123,19 @@ public class ParquetFileReader implements Closeable {
public static String PARQUET_READ_PARALLELISM =
"parquet.metadata.read.parallelism";
+ private ParquetMetricsCallback metricsCallback;
+
private final ParquetMetadataConverter converter;
private final CRC32 crc;
+ /**
+ * set a callback to send back metrics info
+ */
+ public void initMetrics(ParquetMetricsCallback callback) {
Review Comment:
Sorry for missing this.
https://github.com/apache/parquet-mr/blob/afd39dde8fd762bf696fea3dab16d45eae1093c3/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetFileReader.java#L669
The `open` method passing a `footer` is deprecated. I think we should
support it with `ParquetReadOptions`. Then Spark could benefit from this as
well.
I am OK with the current changes to unblock this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
