ConeyLiu commented on code in PR #1187:
URL: https://github.com/apache/parquet-mr/pull/1187#discussion_r1441194373
##########
parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ColumnChunkPageReadStore.java:
##########
@@ -88,7 +89,8 @@ static final class ColumnChunkPageReader implements
PageReader {
byte[] fileAAD,
int rowGroupOrdinal,
int columnOrdinal,
- ParquetReadOptions options) {
+ ParquetReadOptions options,
+ ParquetMetricsCallback callback) {
Review Comment:
Why not get the `callback` by the `options.getMetricsCallback`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
