pitrou commented on code in PR #231: URL: https://github.com/apache/parquet-format/pull/231#discussion_r1502424542
########## Encodings.md: ########## @@ -247,6 +253,15 @@ and handled as wrapping around in 2's complement notation so that the original values are correctly restituted. This may require explicit care in some programming languages (for example by doing all arithmetic in the unsigned domain). +One strategy that might be employed to avoid the above mentioned overflow is to Review Comment: This is a rather wordy addition. I think the spec should remain concise. If we want to elaborate on this, we should move the discussion of signedness and bit width to a dedicated "Pitfalls" subsection, IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
