pitrou commented on code in PR #1291:
URL: https://github.com/apache/parquet-mr/pull/1291#discussion_r1516436224
##########
parquet-column/src/main/java/org/apache/parquet/column/ParquetProperties.java:
##########
@@ -420,8 +429,27 @@ public Builder withDictionaryEncoding(String columnPath,
boolean enableDictionar
return this;
}
- public Builder withByteStreamSplitEncoding(boolean enableByteStreamSplit) {
- this.enableByteStreamSplit = enableByteStreamSplit;
+ /**
+ * Enable or disable BYTE_STREAM_SPLIT encoding for FLOAT and DOUBLE
columns.
+ *
+ * @param enable whether BYTE_STREAM_SPLIT encoding should be enabled
+ * @return this builder for method chaining.
+ */
+ public Builder withByteStreamSplitEncoding(boolean enable) {
+ this.enableByteStreamSplit = enable;
+ this.enableExtendedByteStreamSplit &= enable;
+ return this;
+ }
+
+ /**
+ * Enable or disable BYTE_STREAM_SPLIT encoding for FLOAT, DOUBLE, INT32,
INT64 and FIXED_LEN_BYTE_ARRAY columns.
+ *
+ * @param enable whether BYTE_STREAM_SPLIT encoding should be enabled
+ * @return this builder for method chaining.
+ */
+ public Builder withExtendedByteStreamSplitEncoding(boolean enable) {
Review Comment:
I'll take a look at how easy it is to add this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
