gszadovszky commented on code in PR #1291: URL: https://github.com/apache/parquet-mr/pull/1291#discussion_r1516546571
########## parquet-column/src/main/java/org/apache/parquet/column/values/bytestreamsplit/ByteStreamSplitValuesReaderForFLBA.java: ########## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.parquet.column.values.bytestreamsplit; + +import org.apache.parquet.io.api.Binary; + +public class ByteStreamSplitValuesReaderForFLBA extends ByteStreamSplitValuesReader { + private final byte[] valueByteBuffer; + + public ByteStreamSplitValuesReaderForFLBA(int length) { + super(length); + valueByteBuffer = new byte[length]; + } + + @Override + public Binary readBytes() { + gatherElementDataFromStreams(valueByteBuffer); + return Binary.fromConstantByteArray(valueByteBuffer); Review Comment: I've only caught this because I've already had similar problems with Binary. Unfortunately, the parquet-mr code base is not famous from the precise API contracts defined. I think it can cause issues where the Binary value is used as is in the representation. For example if you would read a file using a `ParquetReader<Group>`. I am not sure which is the best approach, to decode the whole page at once or copy the values one-by-one using `Binary`. For the first one you would definitely want to use a `ByteBufferAllocator` so the user can decide if they want to use heap or direct memory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
