gszadovszky commented on code in PR #1291:
URL: https://github.com/apache/parquet-mr/pull/1291#discussion_r1516548850
##########
parquet-column/src/main/java/org/apache/parquet/column/values/factory/DefaultV2ValuesWriterFactory.java:
##########
@@ -84,10 +92,25 @@ private ValuesWriter getBooleanValuesWriter() {
}
private ValuesWriter getFixedLenByteArrayValuesWriter(ColumnDescriptor path)
{
- ValuesWriter fallbackWriter = new DeltaByteArrayWriter(
- parquetProperties.getInitialSlabSize(),
- parquetProperties.getPageSizeThreshold(),
- parquetProperties.getAllocator());
+ final ValuesWriter fallbackWriter;
+ // Heuristic: enable BYTE_STREAM_SPLIT for DECIMAL and FLOAT16 columns.
+ final boolean useByteStreamSplit =
parquetProperties.isExtendedByteStreamSplitEnabled()
Review Comment:
Maybe let the user decide for now and create an additional jira to implement
smart heuristics. Then, some additional time can be spent on experimenting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
