ahshahid commented on code in PR #1309:
URL: https://github.com/apache/parquet-mr/pull/1309#discussion_r1554077960
##########
parquet-column/src/main/java/org/apache/parquet/column/values/bitpacking/BitPackingValuesWriter.java:
##########
@@ -108,7 +109,11 @@ public void reset() {
@Override
public void close() {
- out.close();
+ try (CapacityByteArrayOutputStream cbaos = out) {
+ cbaos.flush();
Review Comment:
@wgtmac Include them .. where. could you pls elaborate more? AFAIK, any
outstream which uses in - memory buffers , should be flushed.. When I checked
the hierarchy of the Output streams, I found only those which actually needed
flush.
For eg: DeltaBinaryPackingValuesWriterForInteger, in close() calls
super.close.. And the super.close , has the code for flushing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
