ahshahid commented on code in PR #1309:
URL: https://github.com/apache/parquet-mr/pull/1309#discussion_r1560424528
##########
parquet-common/src/main/java/org/apache/parquet/io/DelegatingPositionOutputStream.java:
##########
@@ -35,7 +35,11 @@ public OutputStream getStream() {
@Override
public void close() throws IOException {
- stream.close();
+ try (OutputStream os = this.stream) {
Review Comment:
I see. well if you all think so, can remove that .. Though the field var is
defined as OutputStream, so in theory could contain a buffered output stream or
any other custom OutputStream with some buffered data and may or may not have
flush implemented or may or may not have flush invoked before close.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
