wgtmac commented on code in PR #1309:
URL: https://github.com/apache/parquet-mr/pull/1309#discussion_r1557860579
##########
parquet-common/src/main/java/org/apache/parquet/io/DelegatingPositionOutputStream.java:
##########
@@ -35,7 +35,11 @@ public OutputStream getStream() {
@Override
public void close() throws IOException {
- stream.close();
+ try (OutputStream os = this.stream) {
Review Comment:
I also suspect that delegate classes like `LittleEndianDataOutputStream` and
`DelegatingPositionOutputStream` should take this complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
