ahshahid commented on code in PR #1309:
URL: https://github.com/apache/parquet-mr/pull/1309#discussion_r1559910596
##########
parquet-column/src/main/java/org/apache/parquet/column/values/bitpacking/BitPackingValuesWriter.java:
##########
@@ -108,7 +109,11 @@ public void reset() {
@Override
public void close() {
- out.close();
+ try (CapacityByteArrayOutputStream cbaos = out) {
+ cbaos.flush();
Review Comment:
makes sense. it is not needed here.. as of now because as you said
CapacityByteArrayOutputStream 's close is sufficient and its flush is a no op.
I can remove it .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
