etseidl commented on code in PR #251: URL: https://github.com/apache/parquet-format/pull/251#discussion_r1635788871
########## LogicalTypes.md: ########## @@ -59,7 +60,7 @@ Compatibility considerations are mentioned for each annotation in the correspond ### STRING -`STRING` may only be used to annotate the binary primitive type and indicates +`STRING` may only be used to annotate the BYTE_ARRAY primitive type and indicates Review Comment: I don't know. For `DECIMAL` the spec calls out "byte arrays, binary and fixed" as valid physical types. I'd take the lack of mention of fixed-length here to indicated that only the `BYTE_ARRAY` physical type is allowed. Do any current implementations allow fixed-length strings? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
