etseidl commented on code in PR #251: URL: https://github.com/apache/parquet-format/pull/251#discussion_r1644861464
########## LogicalTypes.md: ########## @@ -59,7 +60,7 @@ Compatibility considerations are mentioned for each annotation in the correspond ### STRING -`STRING` may only be used to annotate the binary primitive type and indicates +`STRING` may only be used to annotate the BYTE_ARRAY primitive type and indicates Review Comment: The sense I'm getting from the M/L is that people are open to adding it, but haven't seen any evidence that any one actually supports adding `STRING` to `FLBA`. IMO we should ship this as is, and start a new thread to gauge support for actually modifying the spec to allow for fixed length strings. Given the variable width of UTF-8 characters, I'd think padding would have to be added to account for up to 4 bytes per character. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
