etseidl commented on code in PR #251: URL: https://github.com/apache/parquet-format/pull/251#discussion_r1643253963
########## LogicalTypes.md: ########## @@ -228,7 +229,7 @@ integer. A precision too large for the underlying type (see below) is an error. warning * `fixed_len_byte_array`: precision is limited by the array size. Length `n` can store <= `floor(log_10(2^(8*n - 1) - 1))` base-10 digits -* `binary`: `precision` is not limited, but is required. The minimum number of +* `byte_array`: `precision` is not limited, but is required. The minimum number of Review Comment: Yes, the formatting here is odd...all of the type names are lower case. Also, the use of back ticks for type names is inconsistent. Perhaps (as you suggest) for this PR we can solely worry about binary->byte_array, and then do a second pass to fix capitalization and quoting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
